We recently made changes to the proposal pipeline. These surfaced that there is much more complexity than previously recognized. We have a plan to remedy this but it's out of scope for 23.1. Instead we want to remove any refactors that have happened so far and for 23.2 execute on the plan instead.

• kvserver: document reproposals #94633
• kvserver: prevent finished proposal from being present in proposals map #94825
• kvserver: narrow down 'finishing a proposal with outstanding reproposal' #97564
• kvserver: assert uniqueness in registerProposalLocked #97566 (decided this one can remain)
• kvserver: disable assertion 'finished proposal inserted' #97606

This list should be exhaustive but we need to double-check. The 23.1 code should closely match the 22.2 code before this issue can be closed.

Jira issue: CRDB-24997
Epic: CRDB-25287