Skip to content

Makman2/nextgen3-10#4212

Merged
rultor merged 1 commit intomasterfrom
Makman2/NEXTGEN3-10
Nov 6, 2017
Merged

Makman2/nextgen3-10#4212
rultor merged 1 commit intomasterfrom
Makman2/NEXTGEN3-10

Conversation

@Makman2
Copy link
Copy Markdown
Member

@Makman2 Makman2 commented May 10, 2017

The new bears ;)

Makman2
Makman2 commented May 10, 2017
View reviewed changes
Comment thread tests/core/ProjectBearTest.py Outdated

def test_bear_with_parameters(self):
section = Section('test-section')
section['prefix'] = '???'
Copy link
Copy Markdown
Member Author

@Makman2 Makman2 May 10, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should use dashes and underscores so it's better to read... (something like --- for default and ___ here)

@Makman2 Makman2 force-pushed the Makman2/NEXTGEN3-10 branch 3 times, most recently from 67f76b1 to 74808d0 Compare May 13, 2017 13:49
@Makman2
Copy link
Copy Markdown
Member Author

Makman2 commented May 13, 2017 •
edited
Loading

About the coverage problem on Windows: I inserted print statements on the uncovered-lines, and those statements are definitely executed. Maybe an issue with pytest not handling multiprocessing correctly, but measuring coverage for CoreTest did work properly (and stuff there is tested through multiprocessing).

Will investigate further, at least it works under Linux...

@Udayan12167
Copy link
Copy Markdown
Contributor

Udayan12167 commented May 14, 2017

ack db8868c

@Udayan12167
Copy link
Copy Markdown
Contributor

Udayan12167 commented May 14, 2017

ack 74808d0

@Makman2 Makman2 added process/approved The PR is approved and will be merged soon and removed process/pending review labels May 14, 2017
@Makman2
Copy link
Copy Markdown
Member Author

Makman2 commented May 14, 2017

The coverage problem needs still fixing sadly... will look at it soon.

@gitmate-bot
Copy link
Copy Markdown
Collaborator

gitmate-bot commented May 21, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

2 similar comments
@gitmate-bot
Copy link
Copy Markdown
Collaborator

gitmate-bot commented May 28, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot
Copy link
Copy Markdown
Collaborator

gitmate-bot commented Jun 4, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@sils
Copy link
Copy Markdown
Member

sils commented Jun 9, 2017

@Makman2 why was this approved while it fails appveyor?

@sils sils added process/wip and removed process/approved The PR is approved and will be merged soon labels Jun 9, 2017
@Makman2 Makman2 mentioned this pull request Jun 9, 2017
Open
@gitmate-bot
Copy link
Copy Markdown
Collaborator

gitmate-bot commented Jun 16, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

4 similar comments
@gitmate-bot
Copy link
Copy Markdown
Collaborator

gitmate-bot commented Jun 23, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot
Copy link
Copy Markdown
Collaborator

gitmate-bot commented Jun 30, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot
Copy link
Copy Markdown
Collaborator

gitmate-bot commented Jul 7, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot
Copy link
Copy Markdown
Collaborator

gitmate-bot commented Jul 14, 2017

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@Makman2 Makman2 mentioned this pull request Jul 17, 2017
Closed
@Makman2
Copy link
Copy Markdown
Member Author

Makman2 commented Jul 17, 2017

Ugh I was right... pytest does not handle coverage through multiprocesses correctly suddenly. Using a concurrent.futures.ThreadPoolExecutor() produces 100% coverage on the new modules.

@Makman2
Copy link
Copy Markdown
Member Author

Makman2 commented Jul 17, 2017

Filed upstream an issue for pytest-dev/pytest-cov#165.

Current workaround: Use a ThreadPoolExecutor instead of a ProcessPoolExecutor. For that I have to wait until #4349 is implemented to do that nicely (as ProcessPoolExecutor shall stay as a default).

@Makman2 Makman2 added the status/blocked The issue requires other referenced issues/PRs to be solved/merged before being worked on label Jul 17, 2017
@Makman2 Makman2 force-pushed the Makman2/NEXTGEN3-10 branch from 74808d0 to 3c84936 Compare July 21, 2017 16:25
@gitmate-bot
Copy link
Copy Markdown
Collaborator

gitmate-bot commented Oct 2, 2017

Hey! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost!

@gitmate-bot
Copy link
Copy Markdown
Collaborator

gitmate-bot commented Oct 2, 2017

Automated rebase was successful!

@Udayan12167
Copy link
Copy Markdown
Contributor

Udayan12167 commented Oct 10, 2017

ack 37fd45c

@Udayan12167
Copy link
Copy Markdown
Contributor

Udayan12167 commented Oct 10, 2017

ack 48dd390

@Udayan12167
Copy link
Copy Markdown
Contributor

Udayan12167 commented Oct 10, 2017

ack e1b70ce

@Udayan12167
Copy link
Copy Markdown
Contributor

Udayan12167 commented Oct 10, 2017

ack 80afe06

@Makman2 Makman2 mentioned this pull request Oct 23, 2017
Merged
@Makman2 Makman2 force-pushed the Makman2/NEXTGEN3-10 branch from e1b70ce to e478131 Compare October 23, 2017 15:44
@gitmate-bot gitmate-bot added size/M and removed size/L labels Oct 23, 2017
@Makman2
Copy link
Copy Markdown
Member Author

Makman2 commented Oct 23, 2017

reack e478131

@Makman2
core: Add DependencyBear
012cd76 
Allows to submit tasks on a per-dependency-result-basis.

Closes #4425
@Makman2 Makman2 force-pushed the Makman2/NEXTGEN3-10 branch from e478131 to 012cd76 Compare November 6, 2017 13:48
@gitmate-bot gitmate-bot added process/approved The PR is approved and will be merged soon and removed process/pending review labels Nov 6, 2017
@Makman2
Copy link
Copy Markdown
Member Author

Makman2 commented Nov 6, 2017

@rultor merge

@rultor
Copy link
Copy Markdown
Contributor

rultor commented Nov 6, 2017

@rultor merge

@Makman2 OK, I'll try to merge now. You can check the progress of the merge here

@gitmate-bot gitmate-bot removed the process/approved The PR is approved and will be merged soon label Nov 6, 2017
@rultor rultor merged commit 012cd76 into master Nov 6, 2017
@rultor
Copy link
Copy Markdown
Contributor

rultor commented Nov 6, 2017

@rultor merge

@Makman2 Done! FYI, the full log is here (took me 2min)

@gitmate-bot gitmate-bot added the process/approved The PR is approved and will be merged soon label Nov 6, 2017
@Makman2 Makman2 deleted the Makman2/NEXTGEN3-10 branch November 6, 2017 14:57
@gitmate-bot gitmate-bot added process/approved The PR is approved and will be merged soon and removed process/approved The PR is approved and will be merged soon labels Nov 7, 2017
@gitmate-bot gitmate-bot removed the process/approved The PR is approved and will be merged soon label Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meetmangukiya meetmangukiya meetmangukiya left review comments

@gitmate-bot gitmate-bot gitmate-bot left review comments

@jayvdb jayvdb jayvdb requested changes

Assignees

No one assigned

Labels

area/core area/tests difficulty/medium importance/high size/M status/stale type/bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Makman2 @Udayan12167 @gitmate-bot @sils @rultor @jayvdb @meetmangukiya