Bump io_bazel_rules_go -> 0.46.0 #93
Conversation
Signed-off-by: Matthieu MOREL <[email protected]>
|
@adisuissa , WDYT ? I tried this patch here : envoyproxy/envoy#33084 |
There was a problem hiding this comment.
Overall LGTM.
I just want to make sure the changes are propagating all the way down to go-control-plane and Istio, as AFAIK they are they depend on go. The go-control-plane repo is continuously using the latest Envoy build, so if the previous PR(s) landed and works, then I think it should be ok.
@howardjohn for Istio considerations (or forwarding to someone who may be the point of contact).
|
The go-control-plane worked well with the last version, see : envoyproxy/go-control-plane@db0b36a Concerning istio, I don't know where to look |
|
istio repo is here https://github.com/istio/istio - searching on cncf/xds i reckon it shows where the dependencies are set https://github.com/search?q=repo%3Aistio%2Fistio%20cncf%2Fxds&type=code might be worth trying an update there |
Signed-off-by: Matthieu MOREL <[email protected]>
Signed-off-by: Matthieu MOREL <[email protected]>
|
Anytging to add to merge this as the update og go-control-plane and xds in istio is passing ? |
There was a problem hiding this comment.
Thanks @mmorel-35. IIUC istio/istio#50562 implies that it works for everything.
LGTM, thanks!
With the newest version of rules_go, @go_googleapis is not included anymore.
This includes the use of the same version of gazelle an googleapis as rules_go.
It also use golang dependencies as they are use in go.mod weren't used by gazelle.
This is follows envoyproxy/envoy#33063