Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgv_plugin_go : Use protoc_gen_validate instead of xds #92

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

mmorel-35
Copy link
Contributor

com_envoyproxy_protoc_gen_validate provides the go_proto_compiler with this exact same configuration

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Mar 25, 2024

@adisuissa , WDYT ?
This is already applied in envoy, see : envoyproxy/envoy#33061

Copy link

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adisuissa adisuissa merged commit 0335649 into cncf:main Mar 25, 2024
4 checks passed
@mmorel-35 mmorel-35 deleted the pgv_plugin_go branch March 25, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants