build: remove rules_proto dependency and update protobuf version#123
Conversation
dbd6c45 to
9117a26
Compare
b6ec17a to
e4d6bcb
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
c5bbad3 to
ae1eae9
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
|
/cc @phlax , @adisuissa , I believe it's ready for your reviews. it's been tested on envoyproxy/envoy#41335 |
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
thanks @mmorel-35 - really appreciate you doing this work!!!
iiuc - we are adding rules_python etc because we previously pulled it in transitively from rules_proto?
wondering if we could/should break some of the changes out to separate PRs - but also not sure if that would make sense - so happy if we land what works
| GO_VERSION = "1.24.6" | ||
|
|
||
| # Python version for rules_python | ||
| PYTHON_VERSION = "3.11" |
There was a problem hiding this comment.
envoy is using 3.12 - i would say go with that - ive held off 3.13 because imhe it breaks more stuff
…ports.bzl Signed-off-by: Matthieu MOREL <[email protected]>
|
@phlax , The addition of rules_protobuf is related to https://github.com/protocolbuffers/protobuf?tab=readme-ov-file#bazel-with-workspace I updated python version and updated the associated PR in envoy |
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
got it, thanks for clarification - lgtm
Co-authored-by: phlax <[email protected]> Signed-off-by: Matthieu MOREL <[email protected]>
|
It's tested on envoy PR |
|
lgtm, but i dont have write powers in this repo - so @adisuissa will need to sign off |
3 participants
Description
This is removing direct usage of rules_proto in xds. It also updates protobuf version and handle go dependencies.