This repository was archived by the owner on Jun 9, 2022. It is now read-only.
Python3: Fix swig module import#58
Merged
nshmyrev merged 1 commit intocmusphinx:masterfrom Mar 18, 2019
Merged
Conversation
jschueller
added a commit
to jschueller/pocketsphinx
that referenced
this pull request
Dec 17, 2018
Contributor
Author
|
what do you say @nshmyrev ? should this patch and its pocketsphinx counterpart go in now ? |
Contributor
|
Hello Julien. I'm sorry, I kinda lost it, I'll look tomorrow. |
Contributor
Author
|
Cool, thanks |
Contributor
|
Gentle reminder for myself hehe |
Contributor
|
And thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python3 uses absolute imports, so "from sphinxbase import *" does nothing as it thinks you want to import again the current module thats being imported (the sphinxbase directory), so it does not import the swig module (the sphinxbase.py / _sphinbase.so files).
You can try this for yourself on this example:
now use a relative import:
I successfully fixed the import of sphinxbase and pocketsphinx using this fix, tested on python2 & python3 using this docker script: