Fix stack-buffer overflow in WAV chunk ID logging#437
Merged
Conversation
Replace unsafe %s format specifier with %c%c%c%c to prevent reading past the 4-byte non-null-terminated id buffer. Fixes #431
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a stack-buffer overflow vulnerability when logging 4-byte WAV chunk IDs in
ps_config_wavfile.The issue occurs when processing malformed WAV files with unknown chunks. The code used
%sformat specifier with a non-null-terminatedchar[4]buffer, which could read past the buffer boundary during logging.Changes:
%sformat specifier with%c%c%c%cid[0],id[1],id[2],id[3]to prevent buffer over-readVerification steps
idbuffer use safe operations (memcmp with explicit length)Fixes #431