Increase phone support to 256 and simplify bitvector operations#435
Merged
Increase phone support to 256 and simplify bitvector operations#435
Conversation
Increase FSG_PNODE_CTXT_BVSZ from 4 to 8, supporting up to 256 phones instead of 128. This covers all known phonesets without recompilation. Replace compile-time macro variants with generic implementation to simplify code maintenance. The performance impact is negligible as these operations occur during word transitions, not acoustic scoring. Memory impact: ~16 bytes per fsg_pnode (11% increase), typically 160KB-1.6MB additional for medium to large grammars.
Contributor
Author
|
I looked at doing this dynamically at model load time based on the number of phones in the model, but the savings is like 160-240KB total. |
Contributor
Author
|
This still runs fine on existing models with <128 phones |
Contributor
|
Yes, I agree that this is an okay change. For complex grammars there are much worse sources of memory inefficiency in the FSG search code than this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR increases FSG phonetic context support from 128 to 256 phones and simplifies the bitvector implementation for better maintainability. The motivation is that models with large numbers of phones otherwise will fail -- in particular, Chinese -- without recompilation.
Changes
FSG_PNODE_CTXT_BVSZfrom 4 to 8, supporting up to 256 phones (up from 128)Rationale
The previous implementation required recompilation to support larger phonesets. This change:
Memory Impact
fsg_pnode_t: +16 bytes (11% increase from ~144 to ~160 bytes)Testing