Fix pocketsphinx_lm_convert failing due to missing lw/wip parameters#420
Merged
Fix pocketsphinx_lm_convert failing due to missing lw/wip parameters#420
Conversation
Contributor
lenzo-ka
commented
Jul 16, 2025
lenzo-ka
commented
- Modified ngram_model_read() to check if 'lw' and 'wip' parameters exist before trying to read them using ps_config_typeof()
- These decoder-specific parameters are not required for language model conversion tools like pocketsphinx_lm_convert
- Added test_lm_convert to verify language models can be read without these parameters
- Fixes pockestphinx_lm_convert wants missing config args #399
- Modified ngram_model_read() to check if 'lw' and 'wip' parameters exist before trying to read them using ps_config_typeof() - These decoder-specific parameters are not required for language model conversion tools like pocketsphinx_lm_convert - Added test_lm_convert to verify language models can be read without these parameters - Fixes #399
make CI happier
dhdaines
approved these changes
Jul 26, 2025
Contributor
dhdaines
left a comment
dhdaines
left a comment
There was a problem hiding this comment.
Great, thanks, this has been an annoyance for a long time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.