Skip to content

Do not attempt to align phones to impossibly short durations (fixes #339)#354

Merged
dhdaines merged 3 commits intomasterfrom
339-final-state
Jul 20, 2023
Merged

Do not attempt to align phones to impossibly short durations (fixes #339)#354
dhdaines merged 3 commits intomasterfrom
339-final-state

Conversation

@dhdaines
Copy link
Contributor

While we explcitly disable bestpath in the command-line for phone and state alignment due to its tendency to put fake </s> with a duration of a single frame at the end of the utterance, this was not the case in the Python API, either because I forgot, but most likely for Reasons (some people apparently use bestpath with FSG search or alignment, don't ask me why).

This is a more robust fix, which will simply refuse to force-align something to an impossible duration. We may also wish to fix the upstream problem of the fake </s> but that is more complex to do. This at least prevents crashing!

@dhdaines dhdaines merged commit 05cb832 into master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant