Skip to content

Fix install command for Mac and iOS builds#280

Merged
dhdaines merged 1 commit intocmusphinx:masterfrom
mattlarose:fix-macos-ios-builds
Aug 19, 2022
Merged

Fix install command for Mac and iOS builds#280
dhdaines merged 1 commit intocmusphinx:masterfrom
mattlarose:fix-macos-ios-builds

Conversation

@mattlarose
Copy link
Contributor

@mattlarose mattlarose commented Aug 18, 2022

Currently, when building for iOS or Mac (in my case, building for iOS, I have CMAKE_SYSTEM_NAME = iOS ), you'll get this error:

CMake Error at programs/CMakeLists.txt:16 (install):
  install TARGETS given no BUNDLE DESTINATION for MACOSX_BUNDLE executable
  target "pocketsphinx_batch".

Reference to doc mentioned in comment: https://cmake.org/cmake/help/latest/prop_tgt/MACOSX_BUNDLE.html#prop_tgt:MACOSX_BUNDLE

@mattlarose
Copy link
Contributor Author

mattlarose commented Aug 18, 2022

@lenzo-duo FYI

@dhdaines
Copy link
Contributor

dhdaines commented Aug 18, 2022

Cool, thanks! I can probably add a test of installation to the GitHub actions that runs on Mac OS X...

lenzo-ka
lenzo-ka approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@lenzo-ka lenzo-ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhdaines dhdaines merged commit c6cc877 into cmusphinx:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenzo-ka lenzo-ka lenzo-ka approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattlarose @dhdaines @lenzo-ka