Conversation
Contributor
Author
|
Note that supporting 44.1kHz is fairly easy (if not really optimal) as the code to resample the input to an acceptable sampling rate (i.e. a multiple of 8kHz) is already present in the code, just not hooked into the actual VAD API. The reason it can't be done without resampling is that the VAD code, for very good reasons, relies on filters designed and optimized for 8kHz sampled data. Arguably the right approach would be to have a parallel set of filters for 11025Hz data, which is, unfortunately, beyond my abilities in DSP. |
lets go shopping
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incoporate the more or less industry-standard VAD code from WebRTC. Still a draft as it is missing some really important features:
Having this checked in will allow us to unit test it when we add these missing features.