Build a proper Python package#254
Merged
dhdaines merged 8 commits intocmusphinx:masterfrom Jun 10, 2022
dhdaines:master
Merged
Conversation
This was referenced Jun 10, 2022
lenzo-ka
reviewed
Jun 10, 2022
| # This does something, not sure what | ||
| set_property(TARGET bindings PROPERTY SWIG_USE_TARGET_INCLUDE_DIRECTORIES TRUE) | ||
| # Enable parsing the doxygen comments (FIXME: does this work?) | ||
| set_property(TARGET bindings PROPERTY SWIG_COMPILE_OPTIONS -doxygen) |
Contributor
There was a problem hiding this comment.
The answer is "no", for macos anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the very helpful https://github.com/diegoferigo/cmake-build-extension to make a proper Python package, instead of just some random .py and .so files like CMake wants to give you by default. Currently includes no batteries (models, etc) but this could change. Also needs the various helpful improvements from SoundSwallower.
Since the "pocketsphinx" namespace is highly polluted on PyPI, I've grudgingly decided to call it "pocketsphinx5".