Skip to content

Fix windows build #251

Merged
dhdaines merged 5 commits intomasterfrom
cmake_windows_build
Jun 9, 2022
Merged

Fix windows build #251
dhdaines merged 5 commits intomasterfrom
cmake_windows_build

Conversation

@dhdaines
Copy link
Contributor

@dhdaines dhdaines commented Jun 9, 2022

No description provided.

@dhdaines
Copy link
Contributor Author

dhdaines commented Jun 9, 2022

Windows tests are partially fixed by putting everything in the same directory as the DLL, and some adjustments were made so that this works on Unix as well. It's perhaps not the optimal solution, we may prefer to copy the DLL to the programs directory and to a single directory to hold the test binaries. Tests also need to be fixed on Windows as they depend on bash.

@dhdaines dhdaines merged commit 0d101b4 into master Jun 9, 2022
@dhdaines dhdaines deleted the cmake_windows_build branch September 21, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant