Large build system and small API modernizations#250
Merged
dhdaines merged 96 commits intocmusphinx:masterfrom Jun 9, 2022
dhdaines:master
Merged
Large build system and small API modernizations#250dhdaines merged 96 commits intocmusphinx:masterfrom dhdaines:master
dhdaines merged 96 commits intocmusphinx:masterfrom
dhdaines:master
Conversation
lenzo-ka
reviewed
Jun 8, 2022
Contributor
lenzo-ka
left a comment
lenzo-ka
left a comment
There was a problem hiding this comment.
Can you make doxygen not required?
Contributor
Author
|
Sure, in theory it isn’t but there might be some cmake magic needed.
Likewise for swig…
Le mer. 8 juin 2022 à 15:42, Kevin Lenzo ***@***.***> a
écrit :
… ***@***.**** commented on this pull request.
Can you make doxygen not required?
—
Reply to this email directly, view it on GitHub
<#250 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZLYUECNKXW32SQHO7MKSDVODZS7ANCNFSM5YHULO5Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
Author
should be done in 561a4b1 |
Contributor
|
I'm using pyenv, and cmake seems to get a little confused about which SDK to build for -- it complains (but works) at link time about the python version and the current build target. We can figure this out later... ... and more like that. |
This was referenced Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally this would be a couple different PRs. It:
The goal is to get a truly stable release since PocketSphinx is no longer a development system.