Forward declare allphone_clear_segments in allphone_search.c#140
Merged
nshmyrev merged 1 commit intocmusphinx:masterfrom Aug 10, 2018
Merged
Forward declare allphone_clear_segments in allphone_search.c#140nshmyrev merged 1 commit intocmusphinx:masterfrom
nshmyrev merged 1 commit intocmusphinx:masterfrom
Conversation
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous commit broke compilation because the declaration order of the static functions is off (very sorry about that). Rather than moving functions around, it seemed more natural to put this forward declaration in in the same place as the existing one for allphone_backtrace.
Like I should have done last time, I've tested this and it compiles and seems to run correctly (passes the unit tests, doesn't leak).
Edit to add: this resolves #139.