Skip to content

Inclusion of new ECAL PF cluster corrections in Run-3 MC GTs#36377

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
tvami:IncEGammaPF
Dec 7, 2021
Merged

Inclusion of new ECAL PF cluster corrections in Run-3 MC GTs#36377
cmsbuild merged 1 commit intocms-sw:masterfrom
tvami:IncEGammaPF

Conversation

@tvami
Copy link
Copy Markdown
Contributor

@tvami tvami commented Dec 6, 2021

PR description:

Last missing piece for the 12_2_X POG calibrations. Requested in [0], discussed in the AlCaDB meeting today [1] and here [2], I've created new GTs

[0] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4558.html
[1] https://indico.cern.ch/event/1102567/
[2] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4553.html

PR validation:

wf 12034.0,11634.0,7.23,159.0,12434.0,12834.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@tvami
Copy link
Copy Markdown
Contributor Author

tvami commented Dec 6, 2021

test parameters:

  • workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

@tvami
Copy link
Copy Markdown
Contributor Author

tvami commented Dec 6, 2021

urgent

@cmsbuild cmsbuild added the urgent label Dec 6, 2021
@tvami
Copy link
Copy Markdown
Contributor Author

tvami commented Dec 6, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Dec 6, 2021

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Dec 6, 2021

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar smuzaffar modified the milestones: CMSSW_12_2_X, CMSSW_12_3_X Dec 6, 2021
@cmsbuild cmsbuild modified the milestones: CMSSW_12_3_X, CMSSW_12_2_X Dec 6, 2021
@tvami
Copy link
Copy Markdown
Contributor Author

tvami commented Dec 6, 2021

Hi @smuzaffar can we keep this with the CMSSW_12_2_X milestone? @perrotta @qliphy

@tvami
Copy link
Copy Markdown
Contributor Author

tvami commented Dec 6, 2021

Ahh I see you did it, thanks!

@cmsbuild cmsbuild modified the milestones: CMSSW_12_2_X, CMSSW_12_3_X Dec 6, 2021
@tvami
Copy link
Copy Markdown
Contributor Author

tvami commented Dec 6, 2021

@smuzaffar now it's back to CMSSW_12_3_X :)

@smuzaffar
Copy link
Copy Markdown
Contributor

@tvami , you need a new backport PR for 12.2.X. Any PR on master branch will be for 12.3.X

@rappoccio
Copy link
Copy Markdown
Contributor

Can we not just leave this one in 12.2 and then make a separate PR for the main branch? We'd like to get this off the ground in time for ORP tomorrow.

@tvami
Copy link
Copy Markdown
Contributor Author

tvami commented Dec 6, 2021

Can we not just leave this one in 12.2 and then make a separate PR for the main branch? We'd like to get this off the ground in time for ORP tomorrow.

If the milestone change happened in like 30 min from now there wouldnt even be a need for a separate PR, this one would test correctly, signed, and merged in the time frame. @perrotta @qliphy what do you think?

@perrotta
Copy link
Copy Markdown
Contributor

perrotta commented Dec 6, 2021

Can we not just leave this one in 12.2 and then make a separate PR for the main branch? We'd like to get this off the ground in time for ORP tomorrow.

If the milestone change happened in like 30 min from now there wouldnt even be a need for a separate PR, this one would test correctly, signed, and merged in the time frame. @perrotta @qliphy what do you think?

@tvami master release is 12_3_X now.
As announced since longtime (and with a few days delays also) 12_2_X was closed with pre3.
Any (justified) request to backport in 12_2_X will be taken into account as usual, after the PR is merged in master first.

@tvami
Copy link
Copy Markdown
Contributor Author

tvami commented Dec 6, 2021

I created the backport here #36380

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Dec 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-81f4ca/21028/summary.html
COMMIT: afd77df
CMSSW: CMSSW_12_2_X_2021-12-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36377/21028/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-81f4ca/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-81f4ca/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10044 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250608
  • DQMHistoTests: Total failures: 9687
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3240899
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@malbouis
Copy link
Copy Markdown
Contributor

malbouis commented Dec 6, 2021

+alca

  • The failures are many but are only on MC workflows as expected and related in most of the cases to PF variables.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Dec 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Copy Markdown
Contributor

qliphy commented Dec 7, 2021

+1

@cmsbuild cmsbuild merged commit f8acea5 into cms-sw:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants