Skip to content

fix CondDB connection in CondTools/SiStrip miscalibration tools#36361

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
mmusich:fixConddbConnectionSiStripUnitTests
Dec 4, 2021
Merged

fix CondDB connection in CondTools/SiStrip miscalibration tools#36361
cmsbuild merged 1 commit intocms-sw:masterfrom
mmusich:fixConddbConnectionSiStripUnitTests

Conversation

@mmusich
Copy link
Copy Markdown
Contributor

@mmusich mmusich commented Dec 3, 2021

resolves #36319

PR description:

Second follow up to #36319.
Adapt the connection of PoolDBOutputService to use a clone of CondCore.CondDB.CondDB_cfi.CondDB instead of changing the parameters directly.

PR validation:

Unit test run scram b runtests

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Dec 3, 2021

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Dec 3, 2021

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CondTools/SiStrip (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Dec 3, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Dec 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-581c3a/20980/summary.html
COMMIT: 28dd055
CMSSW: CMSSW_12_2_X_2021-12-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36361/20980/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 3041955
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3041933
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
  • Checked 175 log files, 37 edm output root files, 41 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Copy Markdown
Contributor

tvami commented Dec 4, 2021

+db

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Dec 4, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Copy Markdown
Contributor

perrotta commented Dec 4, 2021

+1

  • Fix attempt...

@mmusich mmusich deleted the fixConddbConnectionSiStripUnitTests branch December 6, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

testCondToolsSiStripBuildersReaders fails occasionally

4 participants