Skip to content

Add new salt position options#43

Merged
nitz merged 2 commits intocmdwtf:mainfrom
SecurityCze:salt_position
Jul 7, 2025
Merged

Add new salt position options#43
nitz merged 2 commits intocmdwtf:mainfrom
SecurityCze:salt_position

Conversation

@SecurityCze
Copy link
Copy Markdown
Contributor

Hello,
hope you are doing well. I finally had a bit of free time again.

This PR should closes #36 and #38, where there are requests for a few different salt position options.

The new options allow the salt to be prefixed/affixed to a word without a separator, and inserted "as another word" (between words, or as first/last word) while using appropriate separators.

The new option in salt position:

image

Example generated passwords:

(numbers represent salt)
(~ is a separator)

Prepend to the beginning of a random word:
romp~4209stoic~toni~worth~avery
hole~ducat~coin~galaxy~0781lot

Appended to the end of a random word:
beat6802~turin~pry~puny~swear
boost~inapt1671~dc~hhh~wast

Insert as a separate word at a random position, once:
2454~moor~fling~bum~bg~seemed
typic~knelt~darry~feud~5447~boss

Notes:

  • I am not exactly happy with the implementation of AsSeparateWordOnce. I would prefer to insert it as another word into the array. But with the current setup, it is more trouble than it is worth. So I think this works just fine.
  • I am a bit worried about how many salt position options are there now. It might soon become too confusing. Let me know if you want me to only add some of them.

@nitz
Copy link
Copy Markdown
Contributor

nitz commented Jul 7, 2025

I am a bit worried about how many salt position options are there now. It might soon become too confusing. Let me know if you want me to only add some of them.

I think this has been the largest factor in my hesitation with these sorts of things in general, and I'm glad you are cognizant of it too.

In a vacuum, I 100% believe that more options are better. No piece of software can ever cover everyone's workflows, but I like customization to the point that most can get what they want out of it. But like you say, it too often feels like everything ends up
embodying Eric Burke's legendary comic. 😂

As this particular change stands, I think it's acceptable as is. But with the inevitability of wanting it to do more in the future, I very much welcome ideas on how to handle an ever increasing number of knobs to tweak. (After all, we all know what happens when you "give a mouse a cookie" haha!)

@nitz nitz merged commit d07f9bd into cmdwtf:main Jul 7, 2025
@nitz nitz mentioned this pull request Aug 12, 2025
@feelnrg
Copy link
Copy Markdown

feelnrg commented Aug 24, 2025

I would also appreciate a reduction in the salt options, as they overlap somewhat. If each option were implemented separately instead of static settings, everyone could configure it themselves:

These are sufficient in my opinion:
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An Easily Fixable Security Issue – Kindly Requesting a Fix

3 participants