Skip to content

do not use GLOB in cmake for source file lists #68

@cmangos-bot

Description

@cmangos-bot

Created by @DasBlub on 2013-02-13 08:46:24
Closed on 2013-03-02 10:38:37


cmake does not recommend using GLOB to gather source file lists*, because that way, cmake does not recognize when a new file has been added and can not automatically regenerate the project-/make files. as we seldom add new files, it should not be too much trouble to add them by hand.

i suggest to convert all cmake files to using a hand-written list of all source files. this also goes hand in hand with issue #67

* see their remark on the file command:

We do not recommend using GLOB to collect a list of source files from your source tree. If no CMakeLists.txt file changes when a source is added or removed then the generated build system cannot know when to ask CMake to regenerate.

this of course counts for all cmangos repositories, not only for wotlk.

feedback would be appreciated.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions