#121 Added support for configured databasechangelog/lock table names. #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This is fantastic -- I have had a look through and it looks really solid. I'm going to discuss with Knut (olavloite) next week and we'll get it merged. Thanks |
olavloite
reviewed
Sep 5, 2022
Collaborator
olavloite
left a comment
olavloite
left a comment
There was a problem hiding this comment.
Thanks for adding this! Looks good to me (with a tiny nit on missing copyright headers)
| @@ -0,0 +1,41 @@ | |||
| package liquibase.ext.spanner.sqlgenerator; | |||
Collaborator
There was a problem hiding this comment.
nit: would you mind adding (just copy-paste) a copyright header to this file and the other test file?
Contributor
Author
There was a problem hiding this comment.
Sure, sorry for missing it.
…log/lock table names.
cbuschka
force-pushed
the
121_cbuschka_customized_changelogtable
branch
from
f9c1e03 to
7158262
Compare
olavloite
approved these changes
Sep 5, 2022
Contributor
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for customization of changelog and changeloglock table names. (see issue #121 )