Skip to content

Fix #437, #438 and #440#439

Merged
manoelcampos merged 33 commits intomasterfrom
issue-437
May 11, 2023
Merged

Fix #437, #438 and #440#439
manoelcampos merged 33 commits intomasterfrom
issue-437

Conversation

@manoelcampos
Copy link
Copy Markdown
Collaborator

@manoelcampos manoelcampos commented May 10, 2023

- Remove useless (unused) attributes vmm, architecture and os
- Update docs

Signed-off-by: Manoel Campos <[email protected]>
to indicate the distribution type of a Datacenter
as public or private (default value).

Signed-off-by: Manoel Campos <[email protected]>
since the implementations of multiple policies in
CloudSim Plus are very different and have a higher performance
than CloudSim's ones.

Update authorship.

Signed-off-by: Manoel Campos <[email protected]>
on VmAllocationPolicyMigrationAbstract

Signed-off-by: Manoel Campos <[email protected]>
Signed-off-by: Manoel Campos <[email protected]>
and because it wasn't being used.

Signed-off-by: Manoel Campos <[email protected]>
to avoid multiple places where a VM destruction
request can be performed, since those different methods were
executing different logics.

Signed-off-by: Manoel Campos <[email protected]>
Signed-off-by: Manoel Campos <[email protected]>
@manoelcampos manoelcampos self-assigned this May 10, 2023
@manoelcampos manoelcampos marked this pull request as draft May 10, 2023 21:46
since the former doesn't have any attributes.

Signed-off-by: Manoel Campos <[email protected]>
- Computes VM live migration time based on the VM RAM utilization
  (allocated capacity) not the total capacity.
- Update VM live migration message

Signed-off-by: Manoel Campos <[email protected]>
implemeting on HostAbstract and VmAbstract.

Moves the VM destruction request from DatacenterBrokerAbstract.requestIdleVmDestruction() to the new VmAbstract.shutdown() method.

Signed-off-by: Manoel Campos <[email protected]>
The Cloudlet.lifeTime empty value is Double.MAX_VALUE,
not -1 anymore.

Signed-off-by: Manoel Campos <[email protected]>
@codacy-production
Copy link
Copy Markdown

codacy-production bot commented May 11, 2023

Coverage summary from Codacy

Merging #439 (8c89541) into master (877776c) - See PR on Codacy

Coverage variation Diff coverage
+0.08% 35.82%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (877776c) 9278 3643 39.27%
Head commit (8c89541) 9285 (+7) 3653 (+10) 39.34% (+0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#439) 134 48 35.82%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@manoelcampos manoelcampos force-pushed the issue-437 branch 3 times, most recently from 6fb8854 to 882b9b9 Compare May 11, 2023 15:13
@manoelcampos manoelcampos force-pushed the issue-437 branch 4 times, most recently from c582fa2 to be38349 Compare May 11, 2023 15:42
@manoelcampos manoelcampos changed the title Fix #437 and #438 Fix #43, #438 and #440 May 11, 2023
@manoelcampos manoelcampos changed the title Fix #43, #438 and #440 Fix #437, #438 and #440 May 11, 2023
@manoelcampos manoelcampos force-pushed the issue-437 branch 2 times, most recently from 6b7b31a to bdbc9f4 Compare May 11, 2023 20:30
…n enum

to be used as a prefix to indicate if a datacenter is in a
public or private cloud.

Changes HostSimple.toString to show the Distribution symbol.

Signed-off-by: Manoel Campos <[email protected]>
Signed-off-by: Manoel Campos <[email protected]>
by calling deallocateResourcesOfVm().

Signed-off-by: Manoel Campos <[email protected]>
those ones which are already created.

Signed-off-by: Manoel Campos <[email protected]>
just to assess a new VM placement.

Signed-off-by: Manoel Campos <[email protected]>
…rectly.

- Calls vm.setCreated inside HostAbstract.createVmInternal.
- Moves Vm.setCreated to VmAbstract since this method cannot be called directly

Signed-off-by: Manoel Campos <[email protected]>
Signed-off-by: Manoel Campos <[email protected]>
it's a non-live migration from/to a public-cloud datacenter.
This way, it's forced to be shutdown and no "running cloudlets"
warning must be shown.

Signed-off-by: Manoel Campos <[email protected]>
when printing logs, so that the toString() method is used instead.

For datacenters, that will show the datacenter distribution
(# for private, + for public-cloud datacenters)

Signed-off-by: Manoel Campos <[email protected]>
Signed-off-by: Manoel Campos <[email protected]>
@manoelcampos manoelcampos marked this pull request as ready for review May 11, 2023 20:40
@manoelcampos manoelcampos merged commit 8f18fbc into master May 11, 2023
@manoelcampos manoelcampos deleted the issue-437 branch May 11, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

1 participant