Skip to content

Close #435#436

Merged
manoelcampos merged 17 commits intomasterfrom
issue-435
May 10, 2023
Merged

Close #435#436
manoelcampos merged 17 commits intomasterfrom
issue-435

Conversation

@manoelcampos
Copy link
Copy Markdown
Collaborator

@manoelcampos manoelcampos commented May 10, 2023

Close #435

Check available examples at cloudsimplus/cloudsimplus-examples#19

to make VmSimple code concise.
Since users may create new Vm implementations,
they may base then from VmSimple.

Since the VmSimple is now small, that makes
it easier for devs to create new classes based on it.

Signed-off-by: Manoel Campos <[email protected]>
from PowerModelHost to Startable.
This way, Hosts, Vms and Cloudlets have these attributes.

Adds these attributes and setters to StartableAbstract class.
Getters are provided by Lombok.

Signed-off-by: Manoel Campos <[email protected]>
Renames AbstractMachine to Machine and AbstractMachineNull to MachineNull.

Signed-off-by: Manoel Campos <[email protected]>
Signed-off-by: Manoel Campos <[email protected]>
to make HostSimple code concise.

Since users may create new Host implementations,
they may base then from HostSimple.

Now that HostSimple is small, that makes
it easier for devs to create new classes based on it.

Signed-off-by: Manoel Campos <[email protected]>
- Introduces ExecDelayable interface and ExecDelayableAbstract class
  containing the startupDelay and shutDownDelay getters and setters.
- Moves startupDelay and shutDownDelay getters and setters from Startable
  to ExecDelayable.
- Makes Machine interface extend ExecDelayable instead of Startable.
- Makes HostAbstract extends ExecDelayableAbstract instead of StartableAbstract
- Makes Vm extends ExecDelayable (since it extends Machine).
  Overrides some methods just to extend documentation.
- Makes CustomerEntity extend ExecDelayable instead of Startable.

Signed-off-by: Manoel Campos <[email protected]>
- Attributes were initialized in wrong order.

Signed-off-by: Manoel Campos <[email protected]>
removing it from the Host.createVm().

Signed-off-by: Manoel Campos <[email protected]>
- Change order of attributes initilization.

Signed-off-by: Manoel Campos <[email protected]>
to use affirmative condition for clarity.

Signed-off-by: Manoel Campos <[email protected]>
- RAM, BW and storage default values were being passed
  in the wrong order

Signed-off-by: Manoel Campos <[email protected]>
to make it easier to detect the root cause of test
failures.

Since we easily forget that test output is redirected
to a file, we spend time trying to figure out
why output is not shown.

Signed-off-by: Manoel Campos <[email protected]>
- Introduces BootModel class and Vm.setBootModel() method
- Creates VmRam subclass to enable getting RAM utilization during VM boot.
- Process VM startup (boot) and shutdown delay.
- Shows specific log to make clear when a Vm shutDownDelay is set or not

Signed-off-by: Manoel Campos <[email protected]>
Signed-off-by: Manoel Campos <[email protected]>
@codacy-production
Copy link
Copy Markdown

codacy-production bot commented May 10, 2023

Coverage summary from Codacy

Merging #436 (b4f38dd) into master (38bf8b0) - See PR on Codacy

Coverage variation Diff coverage
-0.03% 60.57%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (38bf8b0) 9140 3592 39.30%
Head commit (b4f38dd) 9278 (+138) 3643 (+51) 39.27% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#436) 941 570 60.57%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@manoelcampos manoelcampos merged commit 877776c into master May 10, 2023
@manoelcampos manoelcampos deleted the issue-435 branch May 10, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support VM startup/shutdown delay and boot overhead

1 participant