Skip to content

Fix Python 3.10 compatibility #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
potiuk wants to merge 2 commits into from
Closed

Fix Python 3.10 compatibility #14

potiuk wants to merge 2 commits into from

Conversation

@potiuk
Copy link

@potiuk potiuk commented Mar 13, 2022

Fixes: #13

@potiuk
Copy link
Author

potiuk commented Mar 13, 2022

@hg-cs @miguel-cs -> is it possible to merge that single simple change and release a new version of cgroupspy? We are just about to vendor-in cgroups-py in Apache Airlfow : apache/airflow#22209 as this is one of the few last issues that prevent us from providing Python 3.10 compatibility.

@potiuk potiuk mentioned this pull request Mar 13, 2022
Merged
uranusjr
uranusjr reviewed Mar 14, 2022
View reviewed changes
@potiuk
Copy link
Author

potiuk commented Mar 14, 2022

@hg-cs @miguel-cs ?

@potiuk
Copy link
Author

potiuk commented Mar 19, 2022

Hello?

@potiuk
Copy link
Author

potiuk commented Mar 22, 2022

Anyone?

@potiuk
Copy link
Author

potiuk commented Mar 26, 2022

Helo? @hg-cs @miguel-cs ? Anyone still doing anything here? Should we be considering dumping it as a dependency ?

@islavov
Copy link
Contributor

islavov commented Mar 27, 2022

@potiuk original author of the library here. There is a company (cloudsigma) that maintains it, but not sure if it's still a priority for them. Let me try to reach out to them through other channels

@potiuk
Copy link
Author

potiuk commented Mar 27, 2022

Would be fantastic @islavov :). If only to know that we need to look for alternatives. We currently vendored-in the code and fixed it there, but if the library is abandoned, then better to reimplement it :)

@islavov
Copy link
Contributor

islavov commented Mar 27, 2022 via email

@potiuk
Copy link
Author

potiuk commented Mar 27, 2022

Thanks for reaching out @islavov !

@jjlopez
Copy link
Contributor

jjlopez commented Mar 28, 2022

Hello @potiuk,
First of all, sorry for the delaying response, we are taking the needed actions, so this won't happen again.
About the package, we are still maintaining it. Your pull request will be reviewed and merged in the following days. We will keep you posted.

@islavov, thanks for bringing this issue to our attention.

@potiuk
Copy link
Author

potiuk commented Mar 28, 2022

Thanks @jjlopez

@cs-cruz
Copy link
Collaborator

cs-cruz commented Apr 4, 2022

Hello @potiuk, sorry for the delay. We have already reviewed your pull request, we made some additional adjustments to keep the compatibility with Python 2.7 which is still in our plans to maintain. The release is already published.

@cs-cruz cs-cruz closed this Apr 4, 2022
@potiuk
Copy link
Author

potiuk commented Apr 4, 2022

Cool! Thanks. Unvendoring it then :)

potiuk added a commit to potiuk/airflow that referenced this pull request Apr 4, 2022
@potiuk
Unvendor cgroupspy
74383f4 
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible.
We can remove vendoring done as of apache#22209 apache#22208 apache#2207 apache#22206

Discussion and links:

* cloudsigma/cgroupspy#14
@potiuk potiuk mentioned this pull request Apr 4, 2022
Merged
potiuk added a commit to apache/airflow that referenced this pull request Apr 4, 2022
@potiuk
Unvendor cgroupspy (#22736)
f2bdce4 
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible.
We can remove vendoring done as of #22209 #22208 #2207 #22206

Discussion and links:

* cloudsigma/cgroupspy#14
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 10, 2022
@potiuk
Unvendor cgroupspy (#22736)
773ef37 
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible.
We can remove vendoring done as of #22209 #22208 #2207 #22206

Discussion and links:

* cloudsigma/cgroupspy#14

GitOrigin-RevId: f2bdce47df9b69dbc9714bf455435013e178051d
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 30, 2022
@potiuk
Unvendor cgroupspy (#22736)
e6337ed 
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible.
We can remove vendoring done as of #22209 #22208 #2207 #22206

Discussion and links:

* cloudsigma/cgroupspy#14

GitOrigin-RevId: f2bdce47df9b69dbc9714bf455435013e178051d
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 4, 2022
@potiuk
Unvendor cgroupspy (#22736)
6256fdd 
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible.
We can remove vendoring done as of #22209 #22208 #2207 #22206

Discussion and links:

* cloudsigma/cgroupspy#14

GitOrigin-RevId: f2bdce47df9b69dbc9714bf455435013e178051d
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 8, 2022
@potiuk
Unvendor cgroupspy (#22736)
325a962 
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible.
We can remove vendoring done as of #22209 #22208 #2207 #22206

Discussion and links:

* cloudsigma/cgroupspy#14

GitOrigin-RevId: f2bdce47df9b69dbc9714bf455435013e178051d
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Dec 7, 2022
@potiuk
Unvendor cgroupspy (#22736)
465fd4a 
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible.
We can remove vendoring done as of #22209 #22208 #2207 #22206

Discussion and links:

* cloudsigma/cgroupspy#14

GitOrigin-RevId: f2bdce47df9b69dbc9714bf455435013e178051d
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 27, 2023
@potiuk
Unvendor cgroupspy (#22736)
4b3c105 
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible.
We can remove vendoring done as of #22209 #22208 #2207 #22206

Discussion and links:

* cloudsigma/cgroupspy#14

GitOrigin-RevId: f2bdce47df9b69dbc9714bf455435013e178051d
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 12, 2024
@potiuk
Unvendor cgroupspy (#22736)
7eb517d 
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible.
We can remove vendoring done as of #22209 #22208 #2207 #22206

Discussion and links:

* cloudsigma/cgroupspy#14

GitOrigin-RevId: f2bdce47df9b69dbc9714bf455435013e178051d
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 18, 2024
@potiuk
Unvendor cgroupspy (#22736)
2ed7697 
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible.
We can remove vendoring done as of #22209 #22208 #2207 #22206

Discussion and links:

* cloudsigma/cgroupspy#14

GitOrigin-RevId: f2bdce47df9b69dbc9714bf455435013e178051d
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 7, 2024
@potiuk
Unvendor cgroupspy (#22736)
06cbbe0 
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible.
We can remove vendoring done as of #22209 #22208 #2207 #22206

Discussion and links:

* cloudsigma/cgroupspy#14

GitOrigin-RevId: f2bdce47df9b69dbc9714bf455435013e178051d
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 2, 2025
@potiuk
Unvendor cgroupspy (#22736)
30680f4 
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible.
We can remove vendoring done as of #22209 #22208 #2207 #22206

Discussion and links:

* cloudsigma/cgroupspy#14

GitOrigin-RevId: f2bdce47df9b69dbc9714bf455435013e178051d
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 23, 2025
@potiuk
Unvendor cgroupspy (#22736)
f876393 
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible.
We can remove vendoring done as of #22209 #22208 #2207 #22206

Discussion and links:

* cloudsigma/cgroupspy#14

GitOrigin-RevId: f2bdce47df9b69dbc9714bf455435013e178051d
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 18, 2025
@potiuk
Unvendor cgroupspy (#22736)
05f721e 
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible.
We can remove vendoring done as of #22209 #22208 #2207 #22206

Discussion and links:

* cloudsigma/cgroupspy#14

GitOrigin-RevId: f2bdce47df9b69dbc9714bf455435013e178051d
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 16, 2025
@potiuk
Unvendor cgroupspy (#22736)
2d9036a 
The 0.2.2 release of `cgroupspy` makes it Python 3.10 compatible.
We can remove vendoring done as of #22209 #22208 #2207 #22206

Discussion and links:

* cloudsigma/cgroupspy#14

GitOrigin-RevId: f2bdce47df9b69dbc9714bf455435013e178051d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@uranusjr uranusjr uranusjr left review comments

@islavov islavov islavov approved these changes

@anteverse anteverse anteverse approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python 3.10 compatibility

6 participants

@potiuk @islavov @jjlopez @cs-cruz @uranusjr @anteverse