feat(share): add Open Graph support for social media previews by WittF · Pull Request #3227 · cloudreve/cloudreve

WittF · 2026-01-22T11:32:28Z

HFO4 · 2026-01-22T11:46:07Z

For a single shared file, is it a easy job to get thumbnail as the hero image?

WittF · 2026-01-22T13:12:14Z

For a single shared file, is it a easy job to get thumbnail as the hero image?

This need adding a new public thumbnail endpoint.
Personally, I think a consistent logo looks cleaner than file thumbnails🌼

YUDONGLING · 2026-01-22T16:13:41Z

As enhancement, maybe later we can add multi-language support (like email template) & also support magic variables?

WittF · 2026-01-23T03:37:57Z

As enhancement, maybe later we can add multi-language support (like email template) & also support magic variables?

Good idea!
Though social media bot typically don't send Accept-Language headers, so multi-language auto-detection may not work well.
But customizable templates with magic variables sounds great, I'll give it a try✊

inventory/migration.go

service/share/visit.go

assets

routers/controllers/share.go

inventory/setting.go

routers/controllers/share.go

HFO4 · 2026-01-23T08:00:03Z

As enhancement, maybe later we can add multi-language support (like email template) & also support magic variables?

Good idea! Though social media bot typically don't send Accept-Language headers, so multi-language auto-detection may not work well. But customizable templates with magic variables sounds great, I'll give it a try✊

Localization for open graph is hard to implement, I don't think they have a standard for that. For now, we'd better use a unified template, and try not to include language specific phrase, If you have to, use English for now.

- Detect social media bots (Facebook, Twitter, Discord, etc.) - Render OG meta tags with file name, size, and owner info - Auto-redirect to share page after preview is rendered

- Handle invalid/expired/password-protected shares gracefully - Show appropriate messages for login-required shares - Simplify bot detection to social media crawlers only - Extract isShareUnlocked() for code reuse

- Extend ShareOGData with additional fields for richer previews - Add magic variable replacement for File/Folder/Status scenarios - Refactor status handling with switch/case pattern - Separate rendering paths for files, folders, and status messages

- Extract LoadShareForInfo() and BuildRedirectURL() to pkg/share - Move OG template and preview logic to pkg/sharepreview - Extract IsSocialMediaBot() to pkg/util - Simplify service/share/visit.go to use new packages

Intercept /home route for social media bots viewing cloudreve://share paths and render OG preview directly.

WittF · 2026-01-23T13:00:37Z

As enhancement, maybe later we can add multi-language support (like email template) & also support magic variables?

Good idea! Though social media bot typically don't send Accept-Language headers, so multi-language auto-detection may not work well. But customizable templates with magic variables sounds great, I'll give it a try✊

Localization for open graph is hard to implement, I don't think they have a standard for that. For now, we'd better use a unified template, and try not to include language specific phrase, If you have to, use English for now.

State	Title	Description	Source
File	`{file_name}`	`{file_size} · {owner_name}`	L60-61
Folder	`{folder_name}`	`Folder · {owner_name}`	L62-63

Status constants (preview.go#L21-L27):

const (  
    ogStatusInvalidLink      = "Invalid Link"                               
    ogStatusShareExpired     = "Share Expired"                                                            
    ogStatusPasswordRequired = "Password Required"                                                             
    ogDefaultFileName        = "Shared File"                                                        
    ogDefaultFolderName      = "Shared Folder"
)

pkg/util/user_agent.go

Add facebookcatalog, meta-externalagent, pinterestbot and organize bot list with comments by platform.

HFO4 · 2026-01-24T07:53:17Z

This feels "vibe coded"—the implementation is becoming messy and far too complicated. We need to stop iterating on this branch. I suggest STOP letting an AI handle another new iteration, or I can take it over myself. If you prefer to continue, please open a fresh PR.

HFO4 · 2026-01-24T07:33:59Z

middleware/frontend.go

+	return shareURI
+}
+
+func sanitizeInvalidPercentEscapes(raw string) string {


Can you explain why it this needed?

HFO4 · 2026-01-24T07:36:11Z

middleware/frontend.go

+	shareURI, err := filemanagerfs.NewUriFromString(raw)
+	if err != nil {
+		sanitized := sanitizeInvalidPercentEscapes(raw)
+		if sanitized != raw {
+			shareURI, err = filemanagerfs.NewUriFromString(sanitized)
+		}
+	}
+	if err != nil && strings.Contains(raw, "%") {
+		unescaped, err := url.QueryUnescape(raw)
+		if err == nil {
+			shareURI, err = filemanagerfs.NewUriFromString(unescaped)
+			if err != nil {
+				sanitized := sanitizeInvalidPercentEscapes(unescaped)
+				if sanitized != unescaped {
+					shareURI, err = filemanagerfs.NewUriFromString(sanitized)


I don't get what you're doing here.

HFO4 · 2026-01-24T07:37:58Z

middleware/frontend.go

+	c.Header("Content-Type", "text/html; charset=utf-8")
+	c.String(http.StatusOK, html)


c.HTML does the exact same thing in one line.

HFO4 · 2026-01-24T07:43:18Z

pkg/share/share.go

+// LoadShareForInfo loads share info for public preview/metadata access.
+func LoadShareForInfo(ctx context.Context, shareClient inventory.ShareClient, shareID int, viewer *ent.User, password string) (*ent.Share, bool, LoadStatus, error) {
+	ctx = context.WithValue(ctx, inventory.LoadShareUser{}, true)
+	ctx = context.WithValue(ctx, inventory.LoadShareFile{}, true)
+	share, err := shareClient.GetByID(ctx, shareID)
+	if err != nil {
+		if ent.IsNotFound(err) {
+			return nil, false, LoadNotFound, nil
+		}
+		return nil, false, LoadError, err
+	}
+
+	if err := inventory.IsValidShare(share); err != nil {
+		return share, false, LoadExpired, err
+	}
+
+	unlocked := isShareUnlocked(share, password, viewer)
+	return share, unlocked, LoadOK, nil
+}


You're still duplicating existing codes. Please reuse https://github.com/cloudreve/cloudreve/blob/47218607ff91727c404710d8f0c7895c16b201bc/service/share/visit.go#L60C31-L60C32

WittF · 2026-01-24T08:50:24Z

@HFO4 Sorry! I admit my fault.🥲
I let OpenAI Codex review and optimize my change after the basics, then had it review its own work in a new session. This indeed generate a lot of complex and even useless "garbage".
I'll redo this myself and open a new PR later.🙇‍

WittF marked this pull request as draft January 22, 2026 11:35

WittF force-pushed the master branch 2 times, most recently from 5c41e47 to 3c66839 Compare January 22, 2026 13:24

WittF marked this pull request as ready for review January 22, 2026 13:28

WittF marked this pull request as draft January 23, 2026 03:38

WittF marked this pull request as ready for review January 23, 2026 07:28

WittF force-pushed the master branch from 19c7ac6 to ac319fe Compare January 23, 2026 07:36

HFO4 reviewed Jan 23, 2026

View reviewed changes

WittF marked this pull request as draft January 23, 2026 08:24

WittF added 3 commits January 23, 2026 08:29

feat(share): add Open Graph support for social media previews

99d1c05

- Detect social media bots (Facebook, Twitter, Discord, etc.) - Render OG meta tags with file name, size, and owner info - Auto-redirect to share page after preview is rendered

fix(share): improve OG preview with edge cases and code reuse

5e02fbc

- Handle invalid/expired/password-protected shares gracefully - Show appropriate messages for login-required shares - Simplify bot detection to social media crawlers only - Extract isShareUnlocked() for code reuse

WittF force-pushed the master branch from ac319fe to 017e52d Compare January 23, 2026 09:26

WittF added 2 commits January 23, 2026 12:50

refactor(share): extract share logic to reusable packages

bac8908

- Extract LoadShareForInfo() and BuildRedirectURL() to pkg/share - Move OG template and preview logic to pkg/sharepreview - Extract IsSocialMediaBot() to pkg/util - Simplify service/share/visit.go to use new packages

feat(share): add OG preview for home route share links

4ef97bf

Intercept /home route for social media bots viewing cloudreve://share paths and render OG preview directly.

WittF marked this pull request as ready for review January 23, 2026 13:00

WittF requested a review from HFO4 January 23, 2026 13:00

YUDONGLING reviewed Jan 24, 2026

View reviewed changes

pkg/util/user_agent.go Show resolved Hide resolved

fix(share): add more social media bot user agents

d9f0612

Add facebookcatalog, meta-externalagent, pinterestbot and organize bot list with comments by platform.

HFO4 reviewed Jan 24, 2026

View reviewed changes

WittF closed this Jan 24, 2026

WittF mentioned this pull request Jan 24, 2026

feat(share): add Open Graph preview for social media crawlers #3234

Merged

		c.Header("Content-Type", "text/html; charset=utf-8")
		c.String(http.StatusOK, html)

Uh oh!

Conversation

WittF commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HFO4 commented Jan 22, 2026

Uh oh!

WittF commented Jan 22, 2026

Uh oh!

YUDONGLING commented Jan 22, 2026

Uh oh!

WittF commented Jan 23, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HFO4 commented Jan 23, 2026

Uh oh!

WittF commented Jan 23, 2026

Uh oh!

Uh oh!

HFO4 commented Jan 24, 2026

Uh oh!

HFO4 Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

HFO4 Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

HFO4 Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

HFO4 Jan 24, 2026

Choose a reason for hiding this comment

Uh oh!

WittF commented Jan 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

WittF commented Jan 22, 2026 •

edited

Loading