feat(scalar): Support pointer dereferencing in decimal #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevgenypats
approved these changes
Jun 1, 2023
yevgenypats
approved these changes
Jun 1, 2023
erezrokah
force-pushed
the
feat/decimal_support_unwrapping
branch
from
55e666f to
583a757
Compare
disq
approved these changes
Jun 1, 2023
⏱️ Benchmark results
|
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
🤖 I have created a release *beep* *boop* --- ## [3.10.0](v3.9.0...v3.10.0) (2023-06-01) ### Features * **scalar:** Support all int variations in decimal scalar ([#937](#937)) ([159e975](159e975)) * **scalar:** Support pointer dereferencing in decimal ([#938](#938)) ([181e676](181e676)) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 7f8dd24 ([#936](#936)) ([8cfc215](8cfc215)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to c1359c5 ([#933](#933)) ([dab8d86](dab8d86)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to c67fb39 ([#935](#935)) ([82f5f60](82f5f60)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #937, also needed for cloudquery/cloudquery#11115
When reading data from a database it is common to pass a pointer to a value to support reading
nilvalues, so the type of the value read is a pointer to a pointer.Without this PR, if someone uses the decimal scalar they need to dereference the pointer manually before setting the scalar value.
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)