feat(scalar): Support all int variations in decimal scalar #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevgenypats
approved these changes
Jun 1, 2023
⏱️ Benchmark results
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #937 +/- ##
==========================================
+ Coverage 51.79% 52.04% +0.24%
==========================================
Files 62 62
Lines 6197 6325 +128
==========================================
+ Hits 3210 3292 +82
- Misses 2702 2728 +26
- Partials 285 305 +20
☔ View full report in Codecov by Sentry. |
5 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
Follow up to #937, also needed for cloudquery/cloudquery#11115 When reading data from a database it is common to pass a pointer to a value to support reading `nil` values, so the type of the value read is a pointer to a pointer. Without this PR, if someone uses the decimal scalar they need to dereferences the pointer manually before setting the scalar value. ---
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
🤖 I have created a release *beep* *boop* --- ## [3.10.0](v3.9.0...v3.10.0) (2023-06-01) ### Features * **scalar:** Support all int variations in decimal scalar ([#937](#937)) ([159e975](159e975)) * **scalar:** Support pointer dereferencing in decimal ([#938](#938)) ([181e676](181e676)) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 7f8dd24 ([#936](#936)) ([8cfc215](8cfc215)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to c1359c5 ([#933](#933)) ([dab8d86](dab8d86)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to c67fb39 ([#935](#935)) ([82f5f60](82f5f60)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added due to cloudquery/cloudquery#11115, where I'm using decimal to represent all different int types.
For the tests of that PR I need to convert Go int types (generated by the test data) to scalars so I can compare with the data read from the database
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)