test(scalar): Add google/uuid test #932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ Benchmark results
|
candiduslynx
approved these changes
Jun 1, 2023
disq
approved these changes
Jun 12, 2023
| {source: nilPointerByteArray, result: UUID{}}, | ||
| {source: nilPointerString, result: UUID{}}, | ||
| {source: &uuid.UUID{}, result: UUID{Value: [16]byte{0}, Valid: true}}, | ||
| {source: uuid.UUID{}, result: UUID{Value: [16]byte{0}, Valid: true}}, |
Contributor
There was a problem hiding this comment.
Please add the uuid.DNSNamespace case as well (ass uuid.Nil is trivial only)
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #932 +/- ##
=======================================
Coverage 48.75% 48.75%
=======================================
Files 87 87
Lines 8086 8086
=======================================
Hits 3942 3942
Misses 3787 3787
Partials 357 357 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #922. 2 more tests. The tests pass since
uuid.UUIDimplements theStringerinterfaceUse the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)