feat: More scalars #914
Merged
feat: More scalars #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ Benchmark results
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #914 +/- ##
==========================================
+ Coverage 48.00% 51.25% +3.24%
==========================================
Files 55 62 +7
Lines 5245 6183 +938
==========================================
+ Hits 2518 3169 +651
- Misses 2464 2729 +265
- Partials 263 285 +22
☔ View full report in Codecov by Sentry. |
s/bigger than/greater than
Co-authored-by: Alex Shcherbakov <[email protected]>
candiduslynx
suggested changes
May 30, 2023
candiduslynx
suggested changes
May 31, 2023
Contributor
candiduslynx
left a comment
candiduslynx
left a comment
There was a problem hiding this comment.
Last bits about stringers
| ) | ||
|
|
||
| type Time struct { | ||
| Int |
Member
There was a problem hiding this comment.
This seems to be the only scalar with Int instead of Value and without a Valid boolean, is that intentional?
Member
Author
There was a problem hiding this comment.
@hermanschaaf yes we're using its valid/value logic.
erezrokah
reviewed
May 31, 2023
5 tasks
candiduslynx
reviewed
Jun 1, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
🤖 I have created a release *beep* *boop* --- ## [3.9.0](v3.8.1...v3.9.0) (2023-06-01) ### Features * More scalars ([#914](#914)) ([f8625e2](f8625e2)) ### Bug Fixes * **scalar:** Handle nil pointer to []byte in uuid and binary ([#922](#922)) ([dac967a](dac967a)) * **testdata:** Match map field names with type ([#930](#930)) ([cec067d](cec067d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
map types