feat(test): Add AllowNull option for test data
#913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ Benchmark results
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
==========================================
- Coverage 47.57% 47.56% -0.01%
==========================================
Files 55 55
Lines 5171 5140 -31
==========================================
- Hits 2460 2445 -15
+ Misses 2448 2432 -16
Partials 263 263
☔ View full report in Codecov by Sentry. |
disq
reviewed
May 29, 2023
disq
approved these changes
May 29, 2023
hermanschaaf
approved these changes
May 30, 2023
yevgenypats
approved these changes
May 30, 2023
candiduslynx
pushed a commit
that referenced
this pull request
May 30, 2023
🤖 I have created a release *beep* *boop* --- ## [3.7.0](v3.6.7...v3.7.0) (2023-05-30) ### Features * **test:** Add `AllowNull` option for test data ([#913](#913)) ([9b911eb](9b911eb)) ### Bug Fixes * Test Decimal type, map type and larger number ranges ([#905](#905)) ([9a3b4ad](9a3b4ad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Jun 1, 2023
…11078) Extracted from #11043 Depends on: * cloudquery/plugin-sdk#913 * apache/arrow#35823 * cloudquery/plugin-sdk#921
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 29, 2023
Return of the code from #913
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to control whether some of the data types should be left non-nullable.
Inspired by ClickHouse and the fact that Arrays, Maps & Tuples are non-nullable.