fix: Test Decimal type, map type and larger number ranges #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ Benchmark results
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
==========================================
- Coverage 47.62% 47.57% -0.06%
==========================================
Files 55 55
Lines 5134 5171 +37
==========================================
+ Hits 2445 2460 +15
- Misses 2426 2448 +22
Partials 263 263
☔ View full report in Codecov by Sentry. |
hermanschaaf
changed the title
yevgenypats
approved these changes
May 30, 2023
candiduslynx
pushed a commit
that referenced
this pull request
May 30, 2023
🤖 I have created a release *beep* *boop* --- ## [3.7.0](v3.6.7...v3.7.0) (2023-05-30) ### Features * **test:** Add `AllowNull` option for test data ([#913](#913)) ([9b911eb](9b911eb)) ### Bug Fixes * Test Decimal type, map type and larger number ranges ([#905](#905)) ([9a3b4ad](9a3b4ad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds:
I found at least 4 surprising bugs in the Elasticsearch implementation through this. Destinations that don't want to support these features right now can still opt to skip the types.