fix(arrow): Allow empty and nil valid param in AppendValues
#847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ Benchmark resultsComparing with 9426d11
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
- Coverage 47.13% 47.09% -0.05%
==========================================
Files 76 76
Lines 7849 7857 +8
==========================================
Hits 3700 3700
- Misses 3650 3654 +4
- Partials 499 503 +4
☔ View full report in Codecov by Sentry. |
candiduslynx
changed the title
nil valid param in AppendValuesnil valid param in AppendValues
yevgenypats
approved these changes
May 5, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
May 5, 2023
🤖 I have created a release *beep* *boop* --- ## [2.5.4](v2.5.3...v2.5.4) (2023-05-05) ### Bug Fixes * **arrow:** Allow empty and `nil` valid param in `AppendValues` ([#847](#847)) ([dafd05b](dafd05b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #823