Skip to content

Conversation

@hermanschaaf
Copy link
Member

Before this change, only table name was supported as arrow Schema metadata.

@hermanschaaf hermanschaaf changed the title feat: Add table description to metadata feat: Add table description to Arrow schema metadata Apr 25, 2023
@github-actions github-actions bot added feat and removed feat labels Apr 25, 2023
@github-actions
Copy link

github-actions bot commented Apr 25, 2023

⏱️ Benchmark results

  • DefaultConcurrencyDFS-2 resources/s: 11,707
  • DefaultConcurrencyRoundRobin-2 resources/s: 12,076
  • Glob-2 ns/op: 250.4
  • TablesWithChildrenDFS-2 resources/s: 25,303
  • TablesWithChildrenRoundRobin-2 resources/s: 25,705
  • TablesWithRateLimitingDFS-2 resources/s: 28.33
  • TablesWithRateLimitingRoundRobin-2 resources/s: 835.9
  • BufferedScanner-2 ns/op: 11.73
  • LogReader-2 ns/op: 38.63

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (01e6649) 47.05% compared to head (c81d5fc) 46.98%.

❗ Current head c81d5fc differs from pull request most recent head e287bbd. Consider uploading reports for the commit e287bbd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
- Coverage   47.05%   46.98%   -0.08%     
==========================================
  Files          76       76              
  Lines        7861     7869       +8     
==========================================
- Hits         3699     3697       -2     
- Misses       3671     3681      +10     
  Partials      491      491              
Impacted Files Coverage Δ
schema/arrow.go 13.39% <0.00%> (-0.44%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kodiakhq kodiakhq bot merged commit 1a8072f into main Apr 26, 2023
@kodiakhq kodiakhq bot deleted the table-description branch April 26, 2023 14:00
candiduslynx pushed a commit that referenced this pull request Apr 28, 2023
🤖 I have created a release *beep* *boop*
---


##
[2.5.0](v2.4.0...v2.5.0)
(2023-04-28)


### Features

* Add table description to Arrow schema metadata
([#824](#824))
([1a8072f](1a8072f))
* **arrow:** Streamline Apache Arrow extension types
([#823](#823))
([f32fac3](f32fac3))
* **test:** Add double migration test
([#827](#827))
([4cd3872](4cd3872))
* Time values are truncated uniformly
([#825](#825))
([ffb97b0](ffb97b0))


### Bug Fixes

* TransformWithStruct/DefaultNameTransformer change for invalid column
names ([#820](#820))
([01e6649](01e6649))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants