Skip to content

chore(testdata): Deprecation notice #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erezrokah merged 3 commits into from
Apr 20, 2023
Merged

chore(testdata): Deprecation notice #812

erezrokah merged 3 commits into from
Apr 20, 2023

Conversation

@candiduslynx
Copy link
Contributor

@candiduslynx candiduslynx commented Apr 19, 2023

Follow-up for #811

@candiduslynx candiduslynx mentioned this pull request Apr 19, 2023
Merged
@github-actions
Copy link

github-actions bot commented Apr 19, 2023 •
edited
Loading

⏱️ Benchmark results

  • DefaultConcurrencyDFS-2 resources/s: 10,628
  • DefaultConcurrencyRoundRobin-2 resources/s: 11,236
  • Glob-2 ns/op: 176.7
  • TablesWithChildrenDFS-2 resources/s: 28,553
  • TablesWithChildrenRoundRobin-2 resources/s: 27,977
  • TablesWithRateLimitingDFS-2 resources/s: 28.44
  • TablesWithRateLimitingRoundRobin-2 resources/s: 816.9
  • BufferedScanner-2 ns/op: 9.285
  • LogReader-2 ns/op: 30.53

disq
disq reviewed Apr 19, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Apr 19, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.08 🎉

Comparison is base (b54e5e1) 46.63% compared to head (879af81) 46.71%.

❗ Current head 879af81 differs from pull request most recent head d28cdc2. Consider uploading reports for the commit d28cdc2 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
+ Coverage   46.63%   46.71%   +0.08%     
==========================================
  Files          76       76              
  Lines        7820     7832      +12     
==========================================
+ Hits         3647     3659      +12     
  Misses       3682     3682              
  Partials      491      491

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@candiduslynx candiduslynx requested a review from disq April 19, 2023 21:40
@erezrokah erezrokah merged commit 1419126 into main Apr 20, 2023
@erezrokah erezrokah deleted the chore/deprecation-notice branch April 20, 2023 07:22
@erezrokah
Copy link
Member

erezrokah commented Apr 20, 2023 •
edited
Loading

Forced merged so we can release this with #813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erezrokah erezrokah erezrokah approved these changes

@yevgenypats yevgenypats Awaiting requested review from yevgenypats

@disq disq Awaiting requested review from disq

Assignees

No one assigned

Labels

automerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@candiduslynx @erezrokah @disq