fix: Fail on empty tables #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
force-pushed
the
fix/fail_on_empty_tables
branch
from
6999422 to
e93ae27
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
==========================================
+ Coverage 46.63% 46.65% +0.02%
==========================================
Files 76 76
Lines 7820 7823 +3
==========================================
+ Hits 3647 3650 +3
Misses 3682 3682
Partials 491 491
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report in Codecov by Sentry. |
β±οΈ Benchmark results
|
yevgenypats
suggested changes
Apr 19, 2023
Contributor
yevgenypats
left a comment
yevgenypats
left a comment
There was a problem hiding this comment.
small but important nit imo :)
specs/source.go
Outdated
| } | ||
|
|
||
| if len(s.Tables) == 0 { | ||
| return fmt.Errorf("tables configuration is required. Hint: try setting tables to [\"*\"] to sync all tables or use `cloudquery tables` to list available tables") |
Contributor
There was a problem hiding this comment.
I think we shouldn't recommend * because then we are back to square 1 in terms of usability. Hint: choose the tables you want to sync
Member
Author
There was a problem hiding this comment.
π― Wasn't sure about that hint too. See 6ef586c
yevgenypats
approved these changes
Apr 20, 2023
erezrokah
pushed a commit
that referenced
this pull request
Apr 20, 2023
π€ I have created a release *beep* *boop* --- ## [2.3.8](v2.3.7...v2.3.8) (2023-04-20) ### Bug Fixes * Fail on empty tables ([#796](#796)) ([1320d32](1320d32)) * **testing:** Add sorting for testing dest migrations ([#814](#814)) ([b1437f1](b1437f1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #790
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code πgolangci-lint runπ¨ (install golangci-lint here)