Skip to content

Conversation

@erezrokah
Copy link
Member

Summary

Same as cloudquery/cloudquery#8489


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines πŸ§‘β€πŸŽ“
  • Run go fmt to format your code πŸ–Š
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests πŸ§ͺ
  • Ensure the status checks below are successful βœ…

@github-actions
Copy link

⏱️ Benchmark results

Comparing with 963f03c

  • DefaultConcurrencyDFS-2 resources/s: 11,555 ⬆️ 5.12% increase vs. 963f03c
  • DefaultConcurrencyRoundRobin-2 resources/s: 12,489 ⬆️ 4.22% increase vs. 963f03c
  • Glob-2 ns/op: 179.1 ⬇️ 34.12% decrease vs. 963f03c
  • TablesWithChildrenDFS-2 resources/s: 28,787 ⬆️ 1.01% increase vs. 963f03c
  • TablesWithChildrenRoundRobin-2 resources/s: 24,343 ⬇️ 20.04% decrease vs. 963f03c
  • TablesWithRateLimitingDFS-2 resources/s: 28.23 ⬇️ 0.21% decrease vs. 963f03c
  • TablesWithRateLimitingRoundRobin-2 resources/s: 824.1 ⬇️ 2.48% decrease vs. 963f03c
  • BufferedScanner-2 ns/op: 9.453 ⬇️ 19.54% decrease vs. 963f03c
  • LogReader-2 ns/op: 30.51 ⬇️ 20.55% decrease vs. 963f03c

@kodiakhq kodiakhq bot merged commit 78530f8 into main Feb 28, 2023
@kodiakhq kodiakhq bot deleted the erezrokah-patch-1 branch February 28, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants