Skip to content

Conversation

@erezrokah
Copy link
Member

Summary

--verbose makes it very hard to see the actual linting issues reported when looking at the GitHub Action workflow logs


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@github-actions
Copy link

github-actions bot commented Feb 12, 2023

⏱️ Benchmark results

  • DefaultConcurrencyDFS-2 resources/s: 11,113
  • DefaultConcurrencyRoundRobin-2 resources/s: 12,325
  • Glob-2 ns/op: 188.3
  • TablesWithChildrenDFS-2 resources/s: 28,649
  • TablesWithChildrenRoundRobin-2 resources/s: 30,342
  • TablesWithRateLimitingDFS-2 resources/s: 28.39
  • TablesWithRateLimitingRoundRobin-2 resources/s: 784.4
  • BufferedScanner-2 ns/op: 9.377
  • LogReader-2 ns/op: 31.1

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2023

Codecov Report

Base: 47.23% // Head: 47.23% // No change to project coverage 👍

Coverage data is based on head (eefec01) compared to base (77b74b2).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #681   +/-   ##
=======================================
  Coverage   47.23%   47.23%           
=======================================
  Files          70       70           
  Lines        6815     6815           
=======================================
  Hits         3219     3219           
  Misses       3146     3146           
  Partials      450      450           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kodiakhq kodiakhq bot merged commit 309f4c9 into main Feb 12, 2023
@kodiakhq kodiakhq bot deleted the erezrokah-patch-1 branch February 12, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants