feat(spec): Return sources, destinations in order #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Jan 25, 2023
erezrokah
force-pushed
the
feat/spec_dest_sources_order
branch
from
e26f419 to
8b289cd
Compare
⏱️ Benchmark results
|
disq
approved these changes
Jan 25, 2023
erezrokah
force-pushed
the
feat/spec_dest_sources_order
branch
from
8b289cd to
59f0564
Compare
yevgenypats
approved these changes
Feb 23, 2023
erezrokah
force-pushed
the
feat/spec_dest_sources_order
branch
from
f1c437f to
caf515b
Compare
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 23, 2023
🤖 I have created a release *beep* *boop* --- ## [1.40.0](v1.39.1...v1.40.0) (2023-02-23) ### Features * **spec:** Return sources, destinations in order ([#624](#624)) ([4602071](4602071)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Feb 28, 2023
…8403) #### Summary Fixes #7165 (the fix is in the SDK cloudquery/plugin-sdk#624). The changes in the CLI are due to the source reader struct changes <!--
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to cloudquery/cloudquery#7165. This will require a minor code change to the CLI to call
GetDestinationByNamehere and hereUse the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)