fix(testing): Some fixes to the ordering for plugin tests #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
approved these changes
Jan 3, 2023
yevgenypats
approved these changes
Jan 3, 2023
⏱️ Benchmark resultsComparing with 68e2af3
|
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 3, 2023
🤖 I have created a release *beep* *boop* --- ## [1.17.1](v1.17.0...v1.17.1) (2023-01-03) ### Bug Fixes * **testing:** Some fixes to the ordering for plugin tests ([#565](#565)) ([79c2b85](79c2b85)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with append-only tests that only wrote 1 resource: the sort order meant that the incorrect resource was sometimes being compared in this case.
This PR changes the sort order to be by sync time first, then UUID. Some other tests had to be adapted to work with this new ordering as well.