test: Add null-in-text-field test #532
Conversation
erezrokah
left a comment
erezrokah
left a comment
There was a problem hiding this comment.
Looks good but is there anything else we should string? Not sure 🙃
⏱️ Benchmark results
|
shimonp21
changed the title
yevgenypats
left a comment
yevgenypats
left a comment
There was a problem hiding this comment.
Maybe worth live discussion as don't understand the whole context but
return dst.Status == s.Status && strings.ReplaceAll(dst.Str, "\x00", "") == strings.ReplaceAll(s.Str, "\x00", "") seems a line that can cause issues in the future.
Codecov ReportBase: 47.15% // Head: 47.19% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
==========================================
+ Coverage 47.15% 47.19% +0.04%
==========================================
Files 70 70
Lines 6721 6727 +6
==========================================
+ Hits 3169 3175 +6
Misses 3106 3106
Partials 446 446
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Closes cloudquery/cloudquery#5255 after we upgrade the sdk's in the dest-plugins
5 participants
Closes cloudquery/cloudquery#5255 after we upgrade the sdk's in the dest-plugins
Summary
BEGIN_COMMIT_OVERRIDE
fix: Handle null bytes in text fields
END_COMMIT_OVERRIDE
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)