fix: Reduce JSON column schema nesting #1819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marianogappa
approved these changes
Jul 24, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
🤖 I have created a release *beep* *boop* --- ## [4.52.1](v4.52.0...v4.52.1) (2024-07-24) ### Bug Fixes * Don't panic when trying `ToSnake` on `s` character ([#1816](#1816)) ([30e02da](30e02da)) * Properly handle map and slice pointers ([#1817](#1817)) ([8fe9081](8fe9081)) * Reduce JSON column schema nesting ([#1819](#1819)) ([2e1112f](2e1112f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
5 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
#### Summary #1819 fixed it for the gRPC message, but it seems our backend [can't handle](https://github.com/cloudquery/cloudquery-private/actions/runs/10164552583/job/28110217028#step:13:10) the size of the Stripe `tables.json` (see https://stackoverflow.com/questions/59209884/cloud-run-request-limit). With the current default max depth of 4 it's ~40MB. Setting it to 3 lowers it to ~11MB. ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Otherwise we generate too big gRPC messages and the tables command fails:
https://github.com/cloudquery/cloudquery-private/actions/runs/10076465888/job/27856903583#step:6:15
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)