fix: Use tables with primary key in delete-stale tests
#1195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
requested review from
erezrokah,
hermanschaaf and
yevgenypats
as code owners
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1195 +/- ##
==========================================
- Coverage 48.30% 48.29% -0.01%
==========================================
Files 87 87
Lines 8151 8152 +1
==========================================
Hits 3937 3937
- Misses 3857 3858 +1
Partials 357 357
☔ View full report in Codecov by Sentry. |
candiduslynx
added a commit
to cloudquery/cloudquery
that referenced
this pull request
Sep 4, 2023
candiduslynx
added a commit
to cloudquery/cloudquery
that referenced
this pull request
Sep 4, 2023
This was referenced Sep 4, 2023
erezrokah
requested changes
Sep 4, 2023
Member
erezrokah
left a comment
erezrokah
left a comment
There was a problem hiding this comment.
The test change looks good, a question on the code change
erezrokah
approved these changes
Sep 4, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 4, 2023
🤖 I have created a release *beep* *boop* --- ## [4.6.3](v4.6.2...v4.6.3) (2023-09-04) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to cd3d411 ([#1193](#1193)) ([3c5e6dd](3c5e6dd)) * Use tables with primary key in `delete-stale` tests ([#1195](#1195)) ([6dd1730](6dd1730)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Sep 4, 2023
…13568) Extracted from #13492 Depends on cloudquery/plugin-sdk#1195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by:
github.com/cloudquery/plugin-sdk/v4tov4.6.3cloudquery#13568github.com/cloudquery/plugin-sdk/v4tov4.6.3cloudquery#13600BEGIN_COMMIT_OVERRIDE
fix: Use tables with primary key in
delete-staletests (fix: Use tables with primary key indelete-staletests #1195)END_COMMIT_OVERRIDE