fix: Add NoConnection to init request
#1092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
force-pushed
the
fix/add_no_connection
branch
from
20763c5 to
8bf79f7
Compare
⏱️ Benchmark results
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1092 +/- ##
=======================================
Coverage 47.17% 47.17%
=======================================
Files 84 84
Lines 7728 7728
=======================================
Hits 3646 3646
Misses 3748 3748
Partials 334 334
☔ View full report in Codecov by Sentry. |
yevgenypats
approved these changes
Jul 14, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 14, 2023
🤖 I have created a release *beep* *boop* --- ## [4.1.1](v4.1.0...v4.1.1) (2023-07-14) ### Bug Fixes * Add `NoConnection` to init request ([#1092](#1092)) ([ba16cfd](ba16cfd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Jul 14, 2023
#### Summary Goes with cloudquery/plugin-sdk#1092 and cloudquery/plugin-pb-go#62. This ensures the `cloudquery migrate` command does not require authentication to AWS, GCP, Azure, etc. <!--
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Goes with cloudquery/plugin-pb-go#62. I'll update the PR once we release a new version of
plugin-pb-goUse the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)