fix: Add random suffix to test table names #1086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevgenypats
approved these changes
Jul 14, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 14, 2023
🤖 I have created a release *beep* *boop* --- ## [4.1.0](v4.0.0...v4.1.0) (2023-07-14) ### Features * Add `plugin.ValidateNoEmptyColumns` ([#1085](#1085)) ([32e1215](32e1215)) ### Bug Fixes * Add random suffix to test table names ([#1086](#1086)) ([ad16b20](ad16b20)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.7.0 ([#1091](#1091)) ([fb124a2](fb124a2)) * **testing:** Comply with given TimePrecision ([#1089](#1089)) ([d16ed0f](d16ed0f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a random suffix to test table names so that it's possible to run the same test more than once in a second without getting name collisions. I chose a random number here because it's simpler, but I could imagine other solutions like an incrementing counter also working with a bit of additional complexity.