fix: Check record data in tests #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevgenypats
approved these changes
Jul 4, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 4, 2023
🤖 I have created a release *beep* *boop* --- ## [4.7.1-rc1](v4.7.0-rc1...v4.7.1-rc1) (2023-07-04) ### Bug Fixes * Add AddCqIDs helper function ([#1065](#1065)) ([911762d](911762d)) * Check record data in tests ([#1062](#1062)) ([f13e4cc](f13e4cc)) * **configtype:** Add `Equal()` method to `Duration` ([#1059](#1059)) ([57c7bc2](57c7bc2)) * Conversion and test fixes ([#1064](#1064)) ([36b65cb](36b65cb)) * Fix test assertions for records ([#1066](#1066)) ([a9bd88f](a9bd88f)) * **testdata:** Add missing column types ([#1061](#1061)) ([f5d01c9](f5d01c9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds back assertions on the record data in destination writer tests. I'm not sure if we also need to handle ordering somehow here, but I think we can follow up with a fix for that if necessary.