fix: Put null helpers back #1002
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1002 +/- ##
=======================================
Coverage ? 47.94%
=======================================
Files ? 77
Lines ? 7463
Branches ? 0
=======================================
Hits ? 3578
Misses ? 3553
Partials ? 332
☔ View full report in Codecov by Sentry. |
⏱️ Benchmark results
|
| ) | ||
|
|
||
| //nolint:unused | ||
| func stripNullsFromLists(records []arrow.Record) { |
There was a problem hiding this comment.
Why are we adding unused code? Will there be a follow-up where it gets used?
There was a problem hiding this comment.
No, I was just migrating CH when I noticed this missing.
I can comment out the relevant section in CH tests, but it will still be required once we bring the vast testing back
There was a problem hiding this comment.
We can leave this here as a reminder, but can we rather add it back when it's needed?
candiduslynx
force-pushed
the
feat/allow-null-test-opt
branch
from
9961903 to
08edb0f
Compare
candiduslynx
force-pushed
the
feat/allow-null-test-opt
branch
from
08edb0f to
481df65
Compare
candiduslynx
force-pushed
the
feat/allow-null-test-opt
branch
from
481df65 to
4fa4143
Compare
Co-authored-by: Herman Schaaf <[email protected]>
yevgenypats
left a comment
yevgenypats
left a comment
There was a problem hiding this comment.
Im approving to unblock but in general I think we should somehow come with an approach that is either on the plugin side or generalize better otherwise the testing code is going to get out of hand quickly.
🤖 I have created a release *beep* *boop* --- ## [4.3.1-rc1](v4.3.0-rc1...v4.3.1-rc1) (2023-06-29) ### Bug Fixes * Enable double migration test ([#1023](#1023)) ([466796b](466796b)) * Put null helpers back ([#1002](#1002)) ([95ed5df](95ed5df)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Return of the code from #913