Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.5.2
Choose a base ref
...
head repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.6.0
Choose a head ref
  • 5 commits
  • 11 files changed
  • 3 contributors

Commits on May 19, 2023

  1. 1 Configuration menu
    Copy the full SHA
    6967929 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2023

  1. feat: Refactor test options and allow skipping of nulls in lists (#892)

    - Skipping of null values in lists when doing comparisons is necessary for BigQuery tests to pass right now, because BigQuery does not support null values in repeated columns. To keep the migration to Arrow backwards-compatible, we are opting to strip nulls in that case (for now), but we still want our automated tests to pass.
    - This also refactors the test options. Previously you had to call `destination.PluginTestSuiteRunner` with options from the `schema` package, which is a bit unusual and counter-intuitive, and makes it hard to extend with options that relate specifically to the test suite runner. This changes it so that the options passed in are from the `destination` package and passed through to the `schema` package. It's a breaking change, but this functionality hasn't been out for long, will be easy to update, and only affects tests, so I'm hoping users will forgive us for this one.
    hermanschaaf authored May 20, 2023
    1 Configuration menu
    Copy the full SHA
    bc3c251 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2023

  1. Configuration menu
    Copy the full SHA
    faacca6 View commit details
    Browse the repository at this point in the history
  2. fix: Tighter Arrow test cases (#891)

    - Tests lists with 3 elements instead of one, including one null element. This found a good bug in the BigQuery implementation, and I think it might in other implementations as well
    - JSON: we should test with JSON arrays as well because currently our struct transformer will convert lists of embedded structs to JSON arrays
    hermanschaaf authored May 21, 2023
    2 Configuration menu
    Copy the full SHA
    c7f2546 View commit details
    Browse the repository at this point in the history
  3. chore(main): Release v3.6.0 (#890)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ## [3.6.0](v3.5.2...v3.6.0) (2023-05-21)
    
    
    ### Features
    
    * Add precision options for dest testing ([#893](#893)) ([faacca6](faacca6))
    * Refactor test options and allow skipping of nulls in lists ([#892](#892)) ([bc3c251](bc3c251))
    
    
    ### Bug Fixes
    
    * Add null-row case for append-only tests ([#889](#889)) ([6967929](6967929))
    * Tighter Arrow test cases ([#891](#891)) ([c7f2546](c7f2546))
    
    ---
    This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
    cq-bot authored May 21, 2023
    1 Configuration menu
    Copy the full SHA
    70a00d0 View commit details
    Browse the repository at this point in the history
Loading