Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d96344c
Choose a base ref
...
head repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 95d6b80
Choose a head ref
  • 4 commits
  • 12 files changed
  • 3 contributors

Commits on Feb 8, 2023

  1. feat: Use Setpgid=true on Unix systems so that signals are not sent t… 

    …o the child process (#664)

By default, commands in Go are started in the same process group. When a signal is sent (e.g. ctrl+c), this gets sent to the entire group, causing plugins to shut down before the CLI has a chance to do closing operations and then relay the signal. By setting `Setpgid: true` on UNIX systems, we can get better control over the shutdown process of child processes.
    @hermanschaaf
    hermanschaaf authored Feb 8, 2023
    1 Configuration menu
    Copy the full SHA
    2883487 View commit details
    Browse the repository at this point in the history

  2. feat: Add table diff methods (#668) 

    This adds diff methods for `Table`. This will help simplify migrations so we can transform the destination/database into `Table` struct and then understand what was changed/added in the same way across all destination plugins.

PostgreSQL PR example - cloudquery/cloudquery#7819
    @yevgenypats
    yevgenypats authored Feb 8, 2023
    1 Configuration menu
    Copy the full SHA
    f6baa82 View commit details
    Browse the repository at this point in the history

  3. fix: Remove duplicate force implementation (#670) 

    Good catch, force is already implemented via spec and is the right way to go (I got a bit rusty on the SDK :) ) #668 (comment)
    @yevgenypats
    yevgenypats authored Feb 8, 2023
    1 Configuration menu
    Copy the full SHA
    fe34554 View commit details
    Browse the repository at this point in the history

  4. chore(main): Release v1.36.0 (#669) 

    🤖 I have created a release *beep* *boop*
---


## [1.36.0](v1.35.0...v1.36.0) (2023-02-08)


### Features

* Add table diff methods ([#668](#668)) ([f6baa82](f6baa82))
* Use Setpgid=true on Unix systems so that signals are not sent to the child process ([#664](#664)) ([2883487](2883487))


### Bug Fixes

* Remove duplicate force implementation ([#670](#670)) ([fe34554](fe34554))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
    @cq-bot
    cq-bot authored Feb 8, 2023
    1 Configuration menu
    Copy the full SHA
    95d6b80 View commit details
    Browse the repository at this point in the history
Loading