remove formatType

hermanschaaf · hermanschaaf · commit febec9a09037 · 2023-05-22T13:21:21.000+01:00
diff --git a/plugins/source/docs.go b/plugins/source/docs.go
@@ -11,7 +11,6 @@ import (
 	"sort"
 	"text/template"
 
-	"github.com/apache/arrow/go/v13/arrow"
 	"github.com/cloudquery/plugin-sdk/v3/caser"
 	"github.com/cloudquery/plugin-sdk/v3/schema"
 )
@@ -147,7 +146,7 @@ func (p *Plugin) jsonifyTables(tables schema.Tables) []jsonTable {
 		for c, col := range table.Columns {
 			jsonColumns[c] = jsonColumn{
 				Name:             col.Name,
-				Type:             formatType(col.Type),
+				Type:             col.Type.String(),
 				IsPrimaryKey:     col.PrimaryKey,
 				IsIncrementalKey: col.IncrementalKey,
 			}
@@ -204,8 +203,7 @@ func (p *Plugin) renderAllTables(t *schema.Table, dir string) error {
 
 func (p *Plugin) renderTable(table *schema.Table, dir string) error {
 	t := template.New("").Funcs(map[string]any{
-		"formatType": formatType,
-		"title":      p.titleTransformer,
+		"title": p.titleTransformer,
 	})
 	t, err := t.New("table.md.go.tpl").ParseFS(templatesFS, "templates/table.md.go.tpl")
 	if err != nil {
@@ -232,10 +230,6 @@ func formatMarkdown(s string) string {
 	return reMatchHeaders.ReplaceAllString(s, `$1`+"\n\n")
 }
 
-func formatType(v arrow.DataType) string {
-	return v.String()
-}
-
 func indentToDepth(table *schema.Table) string {
 	s := ""
 	t := table
diff --git a/plugins/source/templates/table.md.go.tpl b/plugins/source/templates/table.md.go.tpl
@@ -40,5 +40,5 @@ The following tables depend on {{.Name}}:
 | Name          | Type          |
 | ------------- | ------------- |
 {{- range $column := $.Columns }}
-|{{$column.Name}}{{if $column.PrimaryKey}} (PK){{end}}{{if $column.IncrementalKey}} (Incremental Key){{end}}|{{$column.Type | formatType}}|
+|{{$column.Name}}{{if $column.PrimaryKey}} (PK){{end}}{{if $column.IncrementalKey}} (Incremental Key){{end}}|{{$column.Type}}|
 {{- end }}
