fix: Make retries and retry delay configurable #9941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
requested review from
a team and
candiduslynx
and removed request for
a team
candiduslynx
approved these changes
Apr 13, 2023
Contributor
candiduslynx
left a comment
candiduslynx
left a comment
There was a problem hiding this comment.
some comments, mostly fine
| - `endpoint_url` (string, optional. Default: not used): | ||
| Endpoint URL to make the API requests to. | ||
|
|
||
| - `retries` (integer, optional. Default: 10): |
Contributor
There was a problem hiding this comment.
Suggested change
| - `retries` (integer, optional. Default: 10): | |
| - `retries` (`integer`, optional. Default: `10`): |
Member
Author
There was a problem hiding this comment.
This would be different from the lines above it and other plugins afaict
| - `retries` (integer, optional. Default: 10): | ||
| Number of retries to make when a request fails with a retryable error code. | ||
|
|
||
| - `retry_delay_seconds` (integer, optional. Default: 65): |
Contributor
There was a problem hiding this comment.
Suggested change
| - `retry_delay_seconds` (integer, optional. Default: 65): | |
| - `retry_delay_seconds` (`integer`, optional. Default: `65`): |
candiduslynx
suggested changes
Apr 13, 2023
| Endpoint URL to make the API requests to. | ||
|
|
||
| - `retries` (integer, optional. Default: 10): | ||
| Number of retries to make when a request fails with a retryable error code. |
Contributor
There was a problem hiding this comment.
add retryable to vale
erezrokah
approved these changes
Apr 13, 2023
candiduslynx
approved these changes
Apr 13, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
🤖 I have created a release *beep* *boop* --- ## [2.1.0](plugins-source-snyk-v2.0.1...plugins-source-snyk-v2.1.0) (2023-04-25) ### This Release has the Following Changes to Tables - Table `snyk_reporting_issues` was added - Table `snyk_reporting_latest_issues` was added ### Features * Add `snyk_reporting_issues` table ([#9762](#9762)) ([bf1bfb5](bf1bfb5)) * **snyk:** Rename `snyk_reporting_issues` to `snyk_reporting_latest_issues`, add new `snyk_reporting_issues` table ([#9972](#9972)) ([b585637](b585637)) * **snyk:** Upgrade to `github.com/cloudquery/plugin-sdk/v2` ([#9951](#9951)) ([a9c60f2](a9c60f2)), closes [#9950](#9950) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.45.0 ([#9863](#9863)) ([2799d62](2799d62)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.2.0 ([#10135](#10135)) ([cf33b89](cf33b89)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.2.2 ([#10143](#10143)) ([8f887e0](8f887e0)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.0 ([#10163](#10163)) ([9a7f214](9a7f214)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.1 ([#10175](#10175)) ([5b53423](5b53423)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.3 ([#10187](#10187)) ([b185248](b185248)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.4 ([#10196](#10196)) ([c6d2f59](c6d2f59)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.5 ([#10200](#10200)) ([5a33693](5a33693)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.6 ([#10208](#10208)) ([91c80a7](91c80a7)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.8 ([#10213](#10213)) ([f358666](f358666)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.4.0 ([#10278](#10278)) ([a0a713e](a0a713e)) * **deps:** Update module github.com/cloudquery/snyk-sdk-go to v0.3.0 ([#9893](#9893)) ([9b97cd2](9b97cd2)) * Make retries and retry delay configurable ([#9941](#9941)) ([b2cfaa3](b2cfaa3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snyk_reporting_issuestable #9762